Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add component tests as part of the coverage #468

Merged
merged 6 commits into from
Nov 28, 2022

Conversation

thisthat
Copy link
Member

@thisthat thisthat commented Nov 28, 2022

Signed-off-by: Giovanni Liva [email protected]

Add component tests to the coverage report: https://app.codecov.io/gh/keptn/lifecycle-toolkit/tree/chore%2Funify-coverage

We can see a bump from 57% to 68%

@thisthat thisthat changed the title chore: Add component tests as part of the coverage chore: add component tests as part of the coverage Nov 28, 2022
@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #468 (4aaf588) into main (21b4d5d) will increase coverage by 8.51%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #468      +/-   ##
==========================================
+ Coverage   51.49%   60.01%   +8.51%     
==========================================
  Files          28       28              
  Lines        2101     2101              
==========================================
+ Hits         1082     1261     +179     
+ Misses        920      739     -181     
- Partials       99      101       +2     
Impacted Files Coverage Δ
operator/controllers/common/taskhandler.go 78.07% <0.00%> (+2.63%) ⬆️
operator/controllers/common/evaluationhandler.go 78.63% <0.00%> (+5.98%) ⬆️
operator/controllers/keptnapp/controller.go 77.64% <0.00%> (+11.76%) ⬆️
...or/controllers/keptnworkloadinstance/controller.go 77.31% <0.00%> (+26.28%) ⬆️
operator/controllers/keptntask/controller.go 57.30% <0.00%> (+57.30%) ⬆️
...ptnworkloadinstance/reconcile_prepostevaluation.go 81.81% <0.00%> (+81.81%) ⬆️
...ptnworkloadinstance/reconcile_prepostdeployment.go 90.90% <0.00%> (+90.90%) ⬆️
Flag Coverage Δ
component-tests 51.08% <ø> (?)
keptn-lifecycle-operator 57.02% <ø> (ø)
scheduler 4.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Giovanni Liva <[email protected]>
@thisthat thisthat marked this pull request as ready for review November 28, 2022 08:49
mowies
mowies previously approved these changes Nov 28, 2022
Signed-off-by: Giovanni Liva <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thisthat thisthat merged commit d521669 into main Nov 28, 2022
@thisthat thisthat deleted the chore/unify-coverage branch November 28, 2022 09:38
@keptn-bot keptn-bot mentioned this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants