-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add component tests as part of the coverage #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
thisthat
changed the title
chore: Add component tests as part of the coverage
chore: add component tests as part of the coverage
Nov 28, 2022
Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #468 +/- ##
==========================================
+ Coverage 51.49% 60.01% +8.51%
==========================================
Files 28 28
Lines 2101 2101
==========================================
+ Hits 1082 1261 +179
+ Misses 920 739 -181
- Partials 99 101 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Giovanni Liva <[email protected]>
thisthat
requested review from
thschue,
bacherfl,
mowies and
philipp-hinteregger
as code owners
November 28, 2022 08:49
mowies
previously approved these changes
Nov 28, 2022
Signed-off-by: Giovanni Liva <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
RealAnna
approved these changes
Nov 28, 2022
bacherfl
approved these changes
Nov 28, 2022
mowies
approved these changes
Nov 28, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Giovanni Liva [email protected]
Add component tests to the coverage report: https://app.codecov.io/gh/keptn/lifecycle-toolkit/tree/chore%2Funify-coverage
We can see a bump from 57% to 68%